feat: update atem-connection and atem-state SOFIE-2504 #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nytamin
approved these changes
Sep 28, 2023
| newAtemState.video.auxilliaries[i] = undefined | ||
| } | ||
| } | ||
| const diffOptions = createDiffOptions(mappings) |
There was a problem hiding this comment.
Question: Should we add a device option for enabling/disabling partial control?
There was a problem hiding this comment.
This is currently intended to behave identically to previous versions of TSR in what it will control.
Long term, we should make this more configurable, but I don't want to do that as part of this PR.
packages/timeline-state-resolver/src/integrations/atem/stateBuilder.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release51 #289 +/- ##
==========================================
Coverage 40.60% 40.60%
==========================================
Files 104 104
Lines 9957 9957
Branches 2453 2453
==========================================
Hits 4043 4043
Misses 5374 5374
Partials 540 540 ☔ View full report in Codecov by Sentry. |
Julusian
force-pushed
the
feat/update-atem-connection
branch
from
b9ff5a0 to
d36402b
Compare
Julusian
force-pushed
the
feat/update-atem-connection
branch
from
bc81e7f to
20fe31e
Compare
Julusian
force-pushed
the
feat/update-atem-connection
branch
from
20fe31e to
3b8f5e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature
TSR is using v2.4 of atem-connection, this works perfectly for us, but is a little out of date. This means that when implementing new things, that ends up being done once for v3 and then backported (which sometimes results in almost completely rewriting the change from scratch)
This updates TSR to be using v3 of atem-connection. This includes the ability to control various additional areas of the atem (not yet exposed in TSR), and reworks some areas to be simpler or translate better to models released since v2.0 of atem-connection.
The updated atem-state allows for specifying what to diff. For now, this is setup to perform diffing which will match previous versions of TSR. In the future, we should work on making this dynamic based upon the mappings in the system, so that we only control resources which sofie blueprints/users have specified
atem-connection is also a sofie nrkno project, but a large amount of v3 was contributed by the community (some of which is also part of the nrkno team, but not done on behalf of nrkno)